Hello, it seems like no one is into trading :smile...
# request-review
k
Hello, it seems like no one is into trading 😄 is there anyone to review this (I guess preferable core member)? It seems huge, mostly due to adding tests and meta to local subworkflows and modules.
j
Do you mind trading two smaller PRs?
k
sure 🎉
j
One moment, may have missed a docs update in 169
k
changelog :D
j
GAH
k
you have to give 100 more of those to compensate my trade 🤣
j
Here is another in the meantime 😉
OK the #C062H82UCRG 169 PR should be ready now
Will look through your PR nomw
❤️ 1
Half way through
k
wowextreme teamwork
j
You've got some really weird git output though 😆
I don't know how you've confused it
e.g.
image.png
k
that seems really weird
j
400/450 🫠 will try and finish before my meeting in 15m
🎉 1
Done, all minor comments (mostly 'is the empty string md5sum to be expected), and a couple of stylistic things
So ✅ approved with comments
k
yey! Thank you. I will adress them now
Hey, I just able to apply your comments https://github.com/nf-core/variantbenchmarking/pull/301. Some tests are producing 0 FN,FP or TP. It is not easy to have it all 🫣 But I fixed the most important part, especially skipped or forgatten happy upgrade. Thank you!
I would appreciate if you can quickly review this as well
j
Done!