To add to test datasets or not? I seldom get away ...
# team-maintainers
j
To add to test datasets or not? I seldom get away with 'not' 😄 https://github.com/nf-core/modules/pull/11220
e
Keep me in the loop 😛
j
You are looped! I'm just trying to get a precedent so I can do it next time 😉
🤣 1
j
Left my comment
Copy code
If it's super small and fast to generate, fine to create on the fly.
It's only if you have very large files/slow to download or generate, you should upload to test-datasets
➕ 1
That's my philsophy
And I've argued before
but it was a long time ago so I don't remember why people didn't liek it
m
I thought you were talking about test datasets more generally, but this is the specific case of intermediate test files that might be created by setup. But yes, I agree here that as long as setup doesn't take long, it's fine to use, otherwise upload the intermediate file to test datasets.
j
Approving! I shall point at this when I need it 🙂
🤣 1
⭐ 1
j
Or we can update the specs @Jonathan Manning 😉
homer disappear 1
m
I guess, if setup takes a lot more time than downloading, then it should be put on test datasets
👍 1
j
@Evangelos Karatzas fairly sure this is fine, I'm seeing the Singularity setup having issues all over the place https://github.com/nf-core/modules/pull/11228
✅ 1
Copy code
The singularity shards are all failing at the same step — sudo add-apt-repository -y ppa:apptainer/ppa — with lazr.restfulclient.errors.ServerError: HTTP Error 503: Service Unavailable from launchpad.net. Ubuntu Launchpad is down, so the runners can't install apptainer to run the singularity tests.
^^^ if you're wondering about Singularity stuff today
🚫 2