Here is a small topic migration for `clame` <https...
# request-review
l
Here is a small topic migration for
clame
https://github.com/nf-core/modules/pull/11225/
✅ 1
👀 1
j
Mind trading with the above? 😬
l
Sure !
❤️ 1
j
It's mostly the same :)
(just more modules)
l
Done !
❤️ 1
j
Thanks @Louis Le Nézet I have a meeting now, but will get back to it after
l
Don't hesitate to ping me when you want a new review !
❤️ 1
j
@Louis Le Nézet just re-running the test with new additional stub entry. Just to say I've skipped the suggestion of simplifying the topics command atm, as all I've done is copied over the one someone already added in the main KRAKEN2_KRAKEN2 module - so I just wanted to go for consistency here rather than changing something that I'm assuming someone has properly tested. In the future I agree otherwise it would make sense to update it to simplify it in a separate PR. And same with the comments, that wasn't 'me' on purpose, but
nf-core/tools
removes them during linting, so there isn't much to do about that. I hope that is OK for now.
Done, ready for re-review 🙂 https://github.com/nf-core/modules/pull/11224
l
For the version emission, that's fine for me. For the comments in the meta.yml, this is indeed one of the current limitation of nf-core modules lint --fix. However we often ask to add them back, even if I think that we will soon add them automatically through the tool. My last question, would be : should we add the optional output to the stub test ? What do you think ?
j
1. Thank you <3 2. OK, then I'll add the comments back if that has been the procedure! 3. I think I did 🤔 , it's in the snapshot now:
l
Yeah, I see it now !
Ping me when 2) is done !
j
❤️
Done!
l
Approved !
j
Tahn kyou!