Enabling GPU usage for ribodetector in <#CE8SSJV3N...
# request-reviewj
Jonathan Manning
04/14/2026, 4:26 PMEnabling GPU usage for ribodetector in #CE8SSJV3N. Zero pipeline logic changes, all in module update + config + docs https://github.com/nf-core/rnaseq/pull/1790
approved with comments 1
m
Maxime Garcia
04/14/2026, 4:29 PMLooks big, but easy to review
Maxime Garcia
04/14/2026, 4:30 PMWondering about this new params in case we add GPU support to other tools
j
Jonathan Manning
04/14/2026, 4:32 PMThere was a whole 'thing' recently, and that was discounted: https://nfcore.slack.com/archives/CQY2U5QU9/p1771579583230519
m
Maxime Garcia
04/14/2026, 4:32 PMOk
Maxime Garcia
04/14/2026, 4:33 PMOh yeah I remember now
j
Jonathan Manning
04/14/2026, 4:34 PMThere's complexity because the use cases are slightly different, you don't necessarily want to turn on GPU enablement across the board.
Right now it's just this and parabricks, the case for a single setting may grow if that changes
Jonathan Manning
04/14/2026, 4:34 PMThanks for review!
m
Maxime Garcia
04/14/2026, 4:34 PMYeah, that's fine for me
Maxime Garcia
04/14/2026, 4:35 PMI think we need proper tools selection handling that's consistent over pipelines
Maxime Garcia
04/14/2026, 4:36 PMBetter solutions than skip and run bolleans or huge tools or skip tools lists
Maxime Garcia
04/14/2026, 4:36 PMAnd I think we're making progress along this way
👍 1
2 Views