<@U03HEFYUW3H> <@U03CKGEU3LZ> I think I've fixed y...
# request-review
j
@Anabella Trigila @Nicolas Vannieuwkerke I think I've fixed your subworkflow, but I'd love it if you confirmed I hadn't misinterpreted the intent https://github.com/nf-core/modules/pull/11180
👀 1
n
I'll leave this up to Anabella as I don't know the purpose of the tool well enough here
a
I ported this local subworkflow to nf-core here: https://github.com/nf-core/rnafusion/commit/52b43dd0f279d2412ef00f5ff8ef5a4d4498204d#diff-8a88e53ba373f101b0e4ddaac[…]5776c683ea7f81c8f764faabc87b16 The exact purpose of the tool in the pipeline is probably known by Annick since she implented it originally. I think your changes do make sense, but we can tag her for the final review in case we are overlooking something.
👍 1
j
OK done. Slack is telling me she's on parental leave though, we may need to make a call for now
Can I go ahead and merge for now? Can always revert/ refine when Annick returns if there's anything wrong.
👍 2
s
Yeah, this looks good to me
I don't see any point in the subworkflow as is
j
Thanks!
✅ 1