Two new modules (PR has been reviewed a lor by me ...
# request-review
f
Two new modules (PR has been reviewed a lor by me so I just want a second pair of eyes): https://github.com/nf-core/modules/pull/11053
👀 1
j
Did you follow any of the discussion we've had about using module binaries, e.g. this one? They require Wave to work correctly using Cloud executors, which limits their portability. Fine for some folks, probably not in nf-core, where we'd like the modules to work in as wide a set of scenarios as possible.
This is why I use templates instead in all my script-providing modules. They're not the prettiest, but at least they work everywhere.
FYI @Ben Sherman - this just keeps coming up! Last time I even PR'd a madcap alternate approach.
100 rainbow 1
f
No I never followed them, because I never had this myself. Anyway that is why I posted here 😄
👍 1