we are so close, one last test failing due to running out of space

Just saw you opened a PR from dev to

main

. We usually only do this for releases. is there a specific reason for that PR?

I messed up the order a bit but the goal is to get the tests passing on main, get a thorough review, and drop released 1.0.0 after approval

there is no need to care about

main

before release. Just tell us when

dev

is ready and we will make a review PR.

Haha I thought dev was ready til opening the pr to main and finding all sorts of new issues with the extended tests! Should I drop a message over in the review request channel then?

if you think you are ready for release yes, but you can also first fix the things you found with this PR (without merging to

main

)

Ok, we have been trying to follow the instructions on the docs website, is this still accurate?

ah, okay, so this PR is already the release PR? We should add to the docs to indicate that in the title 🙂 I just wanted to make sure that you are trying to update

main

before a release for consistencies sake or so

I'm not sure exactly supposed to do, I interpreted the workflow to be • make pr to main • Make sure tests pass • Ask for a review from core • Fix anything for the review • Get approval • clean up the version string • Merge the pr • tag the merge commit as the initial release Sorry for the confusion : is this what we should be doing?

yes, except that you can already clean up the version string at this stage. And rename the PR as

Initial release PR

or something similar