Using a patch to strip STAR from the RSEM modules ...
# request-review
j
Using a patch to strip STAR from the RSEM modules in #CE8SSJV3N, since we now run STAR externally and pass alignments to RSEM: https://github.com/nf-core/rnaseq/pull/1752. One less dependency to wrangle, and the pinned STAR version was a problem with ARM.
👀 1
Thanks @Maxime Garcia, commented on your comment 🙂
👀 1
Hey @Maxime Garcia, tiny bit of cleanup for this one? https://github.com/nf-core/rnaseq/pull/1769
👀 1
m
LGTM
Are you missing reviews on any PRs for #CE8SSJV3N?
j
I'm just mopping up failures associated with the release PR's conda testing. Then I'll work harder at getting an external for that one
👍 1
m
good luck, ping me whenever
thankyou 1
j
I think this is the last fix: https://github.com/nf-core/rnaseq/pull/1770
✅ 1
actually no, one more, but almost....