Samuel Terkper Ahuno
04/06/2026, 1:28 AMdorado/basecaller and have a few questions before I open the PR. Looking for reviewer input on two non-standard aspects (no bioconda/BioContainers & GPU label):Samuel Terkper Ahuno
04/06/2026, 1:49 AMnanoporetech/dorado Docker Hub image directly (SHA-pinned to v1.4.0):
container "nanoporetech/dorado:shac8f356489fa8b44b31beba841b84d2879de2088e"
This is the same pattern used by the nf-core/modules parabricks modules (<http://nvcr.io/nvidia/|nvcr.io/nvidia/>...), which also bypass bioconda due to licensing. conda null is set with a comment explaining why.
ONT doesn't publish semver Docker tags yet — I've opened an issue asking for them: nanoporetech/dorado#1584. Once they do, we can replace the SHA with a clean version tag.
Is this approach acceptable for dorado?Samuel Terkper Ahuno
04/06/2026, 1:51 AMprocess_gpu flagged as non-standard by lint
The module uses label 'process_gpu' because dorado requires a CUDA GPU. nf-core/configs defines process_gpu but it's not in the standard set lint checks against (process_single, process_low, process_medium, process_high, process_long), so lint warns about it.
Is process_gpu the correct label for GPU-required tools? Should I also add a secondary standard label (e.g. process_high)?Samuel Terkper Ahuno
04/06/2026, 1:53 AMsahuno:add-dorado-basecaller
Thanks!Samuel Terkper Ahuno
04/06/2026, 1:53 AM