https://nf-co.re logo
Join Slack
Powered by
Does anyone want to jump in on this discussion? <h...
# team-maintainers
j
Does anyone want to jump in on this discussion? https://github.com/nf-core/modules/pull/11098 I’m not too familiar with the tool, but I feel like having 
vcf2zarr/{convert,explode}
and a 
plink2zarr
all originating from the 
bio2zarr
package should be structured in the modules as 
bio2zarr/{vcf2zarr, plink2zarr}
. If so, what should the names be of the modules 
vcf2zarr/{convert,explode}
do we already have sub-sub modules?
😬 1
m
I have feeling it's similar to TABIX BGZIP HTSLIB and so on too
ohno2 1
We list this in TABIX, but maybe it should be htslib
j
I elft coments
🙌 1
thankyou 1
👀 1
m
ok, so what's our plan for TABIX BGZIP HTSLIB?
j
Imo, TABIX should also be refactored to HTSLIB. But I’m not certain why they all got migrated out of 
htlsib
if i go to git blame, you @Maxime Garcia, did that? What changed your mind to change it back to 
htslib/{tabix, bgzip, bgziptabix}
https://github.com/nf-core/modules/pull/179/changes
m
Yeah, because for me I'd say the tool is tabix
but now that we're having this discussion about bio2zarr
I am thinking I was proably in the wrong there
or maybe not
😂 1
HTSlib is shared between so many tools
j
Yeah true
m
We probably don't want samtools, bcftools and tabix all under htslib
shake no 2
so do we want that for bio2zarr?
j
but what about tabix -> samtools?
m
never
elmofire 1
We can argue about bgzip being it's own tool, but never tabix moving to samtools
j
Think a difference with htslib & bio2zarr is that bio2zarr has less then 10 commands i think https://github.com/sgkit-dev/bio2zarr/blob/main/bio2zarr/__main__.py
m
Actually now that I look into tabix/bgzip, tabix/bgziptabix and tabix/tabix, we could probably merge these 3 modules into just one by being smart
doge inception 1
fbwow 1
but that's a job and a discussion for another day
👍 1
j
So for tabix, we’ll leave as is. bio2zarr we merge due to the relative simplicity of it’s subcommands?
👍 1
m
Who commented on the issue apart from Cameron James and you?
j
None yet
m
OK, let me summon people. @Simon Pearce @Rike Hanssen what's your take on this?
TL;DR: Should we go for 
plink2zarr
and 
vcf2zarr
, or should put all in 
bio2zarr
?
for me bio2zarr is the underlying package, similar to htslib for samtools, tabix and so on..., so I would keep separate
f
I would vote for bio2zarr 🙂
Because it only has a handful of commands
s
tabix I think of as an entirely standalone tool to be honest, as the command is 
tabix foo
(but I realise that the same applies here)
I think if I was looking at this module afresh, I would say these are all 
bio2zarr/subtool
👍 1
c
Sounds like it's decided then?
image.png
👍 2
this 2
The new v2 docs have some great examples for dealing with subcommands and sub-sub-commands 🤩 Thank you!
🙌 2
j
Thanks to @Rike Hanssen für that!
🙌 1
c
I feel seen
👀 1
2 Views
Open in Slack
PreviousNext
Powered by