https://nf-co.re logo
Join Slack
Powered by
Did we ever agree on echo ${args} vs. removing def...
# team-maintainers
f
Did we ever agree on echo ${args} vs. removing def args for the stub?
e
Last I knew, is put it everywhere
which is what I do 😛
m
the 
echo
is in the template, so I just do that đŸ€·đŸ»
j
I just do what they tell me to do in the reviews 👀
đŸ€Ł 1
paranoid 1
e
comply for science, or waste time waiting xD
m
I saw somewhere the instructions were to remove it
Unused def args = task.ext.args ?: '' in stub delete it
e
It's not unused if you echo it
probably need to remove that line now from the doc: @James Fellows Yates!
m
Do we really need to echo an empty string though?
j
It might not be an empty string. Hypothetically if you run a pipeline in stub mode you could validate that your args are being applied correctly
this 1
e
But I get that in some cases it will be empty, for sure (probably in most)
m
Most stub tests though aren't setup to emit optional files or do things with the args. I wouldn't use it for testing a pipeline in that way
j
probably need to remove that line now from the doc: @James Fellows Yates!
Remove what?
e
This first line here:
Or is it OK?
j
I think it's fine, if it's unused you may delete it
f
confused dog
j
Is it not clear?
f
I am just confused because I thought you had a strong opinion on echoing the args and now you said just delete the line haha
I think either way is fine but I opted for deleting most of the time so good for me I guess
j
I'm getting more chill in my old age ;)
old man yells at sarek 2
In my many years since 6mo ago
But the specs are the specs and I think it is a reasonable compromise
2 Views
Open in Slack
PreviousNext
Powered by