Hey - I was wondering if one of the core members c...
# request-core
f
Hey - I was wondering if one of the core members could step in and review the PR for our first release: https://github.com/nf-core/variantprioritization/pull/64. Both people who have been assigned told me that they are not available for the next weeks / months and we would like to finalize this first release earlier than that meow coffee
đź‘€ 1
m
who were your assignees?
f
Phil and Sateesh
m
OK, I can do 1 review for them
❤️ 1
ok, so that's a
dev
to
main
PR, but from what I can see,
main
is not as empty as we would like for a core review
f
Can I do something about that? I tried to open a PR to the TEMPLATE branch to see what has been done, but somehow the TEMPLATE branch is not up-to-date so there are more changes listed
m
No worries, we will work this out
no the TEMPLATE is at 3.5.1 but the release PR has 3.5.2
m
yeah, no worries about that
3.5.2 and 3.5.1 have the same TEMPLATE
did a quick first pass
Looking good, but some minor comments
f
Do you think we are on the right path?
m
yes definitively
f
I adapted and merged, is there something else that you think is missing? 🙂
m
I'll have a look ASAP