https://nf-co.re logo
Join Slack
Powered by
A tiny bit of refactoring and modules update in <#...
# request-review
m
A tiny bit of refactoring and modules update in #C01NHS4CC91 https://github.com/nf-core/rnavar/pull/295
✅ 1
I hope I replied to your comments @Louis Le Nézet thanks for the review
I like how picky you are
l
This was something I was actually wondering. I fear to miss important things when I'm reviewing pipeline that I never tried. We don't really have reviewer training in nf-core, even if it's an important role in the community. Maybe it could be nice to have a bitesizetalk on the subject ?
m
Would you be willing to give this talk?
My opinion, is that the more we review the better we are
100 rainbow 1
For me, reviewing for articles on the bioinfo-fr collective blog helped me to write better and help defends my points, and understand what to ask to others and be more picky
👍 1
l
Would you be willing to give this talk?
Absolutely no 🤣 I already have a big imposter syndrom reviewing others pipeline, so given a talk on how to do this reviews ?
m
You are definitively not the only one here with imposter syndrome
l
Before approving the PR, could you just point me where the mutually exclusive opt-in tools and opt-out tools is defined ?
m
of course
j
BUT I MADE DOCS
This was something I was actually wondering. I fear to miss important things when I'm reviewing pipeline that I never tried.
Don't fear that @Louis Le Nézet !
m
ok, so @James Fellows Yates would you be willing to second @Louis Le Nézet into such a bytesize?
j
No but because of time 😬
(otherwise it would be yeS)
Unless @Louis Le Nézet prepared everything and I'm just in the call as the glamourous assistant to answer more difficult questions 😉
l
I said I didn't want to... meow tableflipshakefist
😆 1
m
@Louis Le Nézet who said I was listening
🫠 1
j
I said I didn't want to... meow tableflipshakefist
But it depends on why 😉
Remember I'm an archaeologist by training, why the fuck am I here?!!
m
ok, time to relaunch this idea of an imposter syndrome bytesize
Remember I'm an archaeologist by training, why the fuck am I here?!!
We're more fun?
2 Views
Open in Slack
PreviousNext
Powered by