https://nf-co.re logo
Join Slack
Powered by
Anyone want to yell at me for this before I merge?...
# team-maintainers
j
Anyone want to yell at me for this before I merge? https://github.com/nf-core/modules/pull/11021
m
YEAAH
give me five
šŸ˜† 1
j
I mean, don't feel like you have to yell, and its been approved by Adam, but a bit unconventional with the lack-of-conda thing
m
meh, not the first module with this lack of conda
j
OK cool, just wasn't sure how naughty I was
m
Python 2.7.15?
samtools 1.10?
Are you into ancient DNA now?
šŸ¤£ 1
j
I know, I know. It's abandonware from 2018 but somebody wants it šŸ¤·
m
Sounds like a job for @Edmundā€™s orphanage
j
That's the samtools that came in automatically, I just pinned it after the fact
m
I am not a super fan of the dependencies, but can't argue with the code. To really nitpick I am wondering if more versions from the dependencies should be captured
j
I'm not looking to do full conda lockfile, these were just the primary deps
m
yeah no, I got you there, I am wondering this for the topics
j
Ahh, gotcha
m
But it's really because I was hoping for yelling opportunities, and couldn't find any reasons to
oh wait, one last thing
Could you pin pip
I remember @mashehu asking me for that
j
sure!
m
@James Fellows Yates is the pin pip thingy in the docs somewhere?
m
we should lint for that...
šŸ’Æ 1
j
Thanks guys!
j
Is the what what @Maxime Garcia?
m
what Matthias just referred to in the issue he linked
j
Ok will check later (dentist with Maia)
m
No worries, just wanted to check with you because of #C09H9L3R614
j
Small note: technically you CAN make a bioconda recipe based of just a commit hash as a verison
(but doesn't solve this issue with python 2.7 support)
j
Yeah, it was mostly that, no way of making 2.7 builds from new recipes
šŸ‘ 1
2 Views
Open in Slack
PreviousNext
Powered by