Right now I'm running several samples and I notice...
# mag
d
Right now I'm running several samples and I noticed many BUSCO fails. And digging more deeply into the fails, I noticed that when BUSCO runs in batch mode, if it fails to classify any of the bins, it exits with code 1, even when the rest of the bins have valid results πŸ€¦β€β™‚οΈ I guess we will have to go to the good old for loop for this one.
😱 1
Acually, it's not a BUSCO problem, is how fails are handled in the module, i.e.:
Copy code
if grep 'Run failed; check logs' ${prefix}-busco.batch_summary.txt > /dev/null
    then
        echo "Busco run failed"
        exit 1
    fi
j
@Diego Alvarez Saravia @Jim Downie out of curiosity what's going on with: https://github.com/nf-core/modules/pull/11022/changes ? Was that meant to be a patch? It looks like the offiical BUSCO module was edited but there is no patch
diff
and the
modules.json
hasn't changed πŸ€”
j
It’s a PR to the modules repo πŸ˜‰
j
Oh jesus Christ
Why am I looking at prs at 5am and think I'll actually read it properly πŸ™ƒπŸ™ƒπŸ™ƒ
πŸ˜… 1