Can I have a review on this one ? <https://github....
# request-review
l
Can I have a review on this one ? https://github.com/nf-core/modules/pull/10992
✅ 1
I tested it on phaseimpute and it works like a charm https://github.com/nf-core/phaseimpute/pull/272
Thanks @Maxime Garcia, the version is now snapshoted 🙂
👀 1
m
I think that with:
Copy code
sanitizeOutput(process.out),
                    path(process.out.stitch_map[0][1]).readLines()[0..5],
                    path(process.out.versions_geneticmapconvert[0]).yaml
you capture some output twice
l
Indeed, the
path(process.out.stitch_map[0][1]).readLines()[0..5]
is for me to ensure that the output is nicely formated. Should I remove it, now that I know that it works ?
m
yeah, go for it, you snapshot it
l
Done !
👀 1
m
adding tests and fixing a filename: https://github.com/nf-core/seqinspector/pull/218
👀 1
so you want me to keep the if whatever in tools for this particular subworkflows?
I guess it does make sense
l
It's just that I find it cleaner. Feel free to ask somebody else point of view for this matter 😉
m
no it's fine, I agree with you
Let me see if I can add a local patch to the module that is bothering me and that could do the trick
meh, let's skip that idea, and keep it how it was, much simpler
That's a job for another day
OK, done now, could you ✅ ?
l
Approved !
m
THANKS