<#1051 remove uppmax config reference from sarek.c...
# configs
g
#1051 remove uppmax config reference from sarek.config Pull request opened by kjellinjonas Ran into issues when running sarek 3.8.1 on uppmax. Pipeline crashes since
conf/pipeline/sarek/uppmax.config
is not found and I think this should fix it. uppmax config was removed here: #922 Please follow these steps before submitting your PR: • If your PR is a work in progress, include
[WIP]
in its title • Your PR targets the
master
branch • You've included links to relevant issues, if any Steps for adding a new config profile: • Add your custom config file to the
conf/
directory • Add your documentation file to the
docs/
directory • Add your custom profile to the
nfcore_custom.config
file in the top-level directory • Add your profile name to the
profile:
scope in
.github/workflows/main.yml
• OPTIONAL: Add your custom profile path and GitHub user name to
.github/CODEOWNERS
(
**/<custom-profile>** @<github-username>
) nf-core/configs
👀 1
m
@James Fellows Yates config merging is still blocked except by us
j
What do you mean?
m
I had to use my special power to merge this PR
j
Ah right because tests aren't passing
I think it's OK for nmow
m
yeah, I think so too, just wanted to let you know that WE have to merge every PR until this is fixed
👍 1
j
@pontus has been an absolute boss on that already
p
Actually didn't know that (thought about it but got the impression that users could merge), so whatever I've done is my under-self that's been doing:)
j
Oh ok - if you don't have permissions to force merge for users, let me know so we can elevate your permissions
(I still think our general philosphy of the users merging their own PRs whe nit comes to institutional changes, but for now we will have to do it for them)
party this 1
p
Now I tested and it seems I can't force merge (unless it's been hidden somewhere strange since I ever did it the last time).
m
@James Fellows Yates ok to give @pontus here extra power
j
OK I think I've done it @pontus let me know if you the ability to force merge now
If not I'll bump you up further
p
Doesn't seem to be enough, "Merging is blocked due to failing merge requirements".
m
Can't you force it?
p
I haven't done that in any repo for a while, so they could of course have moved it.
image.png
j
And now?
I have given you god mode 😬
use it wisely
p
Yes, works.
cookie monster
😆 1