Can someone please tell me how to proceed with thi...
# request-review
e
Can someone please tell me how to proceed with this PR?? https://github.com/nf-core/test-datasets/pull/1917 Thanks!
✅ 1
m
Let's wait for @Jonathan Manning to reply
j
For me we should leave files names alone and refer to them by their SHAs when we need something static, but I know I was disagreeing with @Simon Pearce and @James Fellows Yates
m
In principle I agree with you
but in the case of the modules repo and the tests we do, we never use git shas
We've been thinking of improving the tests, @James Fellows Yates and others can talk about it, but for now, I think a version name in the filename is acceptable
j
OK, fair!
m
But, whenever we rethink the test-datasets repo, I know what to change
🤣 1
s
You mean like we've been saying we'll do for the last 2 years?
party this 1
😬 1