Update on MULTIQC_SAV PR, I have branched out from...
# seqinspector
m
Update on MULTIQC_SAV PR, I have branched out from the initial https://github.com/nf-core/seqinspector/pull/209 PR in https://github.com/nf-core/seqinspector/pull/216, due to some heavy refactoring. I think we can save ourselves a lot of duplicate code by always using MULTIQC SAV in lieu of MULTIQC_GLOBAL, and just not providing the rundir when we don't want to use them. That being said, I really liked the ideas in this PR, and I am not rewriting it all for the sake of it. I actually just ended up reusing most of the logic in it, and it's all still in the git history, which is for me the most important I am still working on it, but just wanted to update you on this. And I discovered an issue with the Multiqc sav modules, that somehow doesn't seem to produce any images 😱. But thanks to this investigation we now have amazingly complete tests for #C05663US2B0 -> https://github.com/nf-core/modules/pull/10935 I apoligize for inconvenience, as this will delay the release. but I really hope that we will fix all that ASAP.
👍 1
🙏 1
good news, the multiqc_sav issue is solved -> https://nfcore.slack.com/archives/C05663US2B0/p1773938858525859?thread_ts=1773750217.858509&cid=C05663US2B0 I realise that now my PR 216 has become a beast, so I will report back the improvments for multiqc_sav into the original 209 PR, so that it's easier to review, and will split out this PR 216 into multiple refactoring PRs.
🙏 1