https://nf-co.re logo
Join Slack
Powered by
Adding topics to a few templated modules (hopefull...
# request-review
j
Adding topics to a few templated modules (hopefully I've got the pattern right): https://github.com/nf-core/modules/pull/10931
👀 1
m
we emit versions_<tools>
j
Oh, right, sorry! Fixing...
m
How about we use .yaml to get the actual yml content from the versions.yml in such a case?
💯 1
I believe it's closer to the check @Edmund wants to put in #CE5LG7WMB
j
I was trying to follow the pattern approved in https://github.com/nf-core/modules/pull/10873
👀 1
m
@Simon Pearce do you agree with me?
s
No, I think it should be versions in this case
it can have more than one tool inside the versions file
whereas in the case of using eval, we get separate emits for each tool
j
Makes sense to me, I'll put it back nvm, I didn't push the fix anyway
m
🤔
thinker
ok, we need to document that
So 
versions.yml
emitted via template are sent to the versions topics and emitted via 
versions
only.
📝 1
j
Is this PR good to go then?
✅ 1
m
m
Of course it is
facepalm
shakefist MAXIME GO READ THE DOCS shakefist
5 Views
Open in Slack
PreviousNext
Powered by