Are we outputting yml files via the version topics...
# team-maintainers
j
Are we outputting yml files via the version topics channels now, or at least allowing them where the eval thing doesn't work? https://github.com/nf-core/modules/pull/10873
n
Yes there's an exception for modules using templates. Those should still use the yaml files but pass them to the topic
m
what would be the other way to deal with this? modules binaries and we execute as bash?
j
OK good, does the boilerplate pipeline template code handle that?
No to module binaries due to Wave dep.
m
iep, but if we had it, that would be the solution
right?
n
what would be the other way to deal with this?
Running the scripts as a CLI tool
j
Yep, templates are just the least-worst way of doing module-level custom scripting right now. We should ditch them as soon as we have a better way.
100 rainbow 3
party this 1
j
Can we transfer custom scripts to some repo (
nf-core/modulescripts
?) and package them so they can be easily built into a container?
j
Theoretically yes, practically no.
It's exactly what I did for the 'shinyngs' modules- baked scripts into an external, released repo. But the loop is long to make edits, you end up doing loads of releases of that external repo, I don't think we can force it as a standard.
👍 2
m
maybe we can do that for scripts that we know are stable
I'm sure we have a couple of those in the modules repo
j
No, I don't like it as a thing, we'd end up with a million one-script repos
🤣 1
Some CI-based workaround where we pre-bake containers with scripts in is probably the way to go, and it's been talked about a bit
j
Could also add a tools feature to handle staging scripts from module binaries directly into
bin/
?
j
@Jim Downie - could you add your voice there? I'd love for Ben to hear another voice than mine and Phil's on this. The module bin feature should really just 'work' without the Wave provisos.
m
I added mine too
j
The module bin feature should really just 'work' without the Wave provisos.
Completely agree, I don't understand why it doesn't... I wrote a couple of modules in our nf-core-style modules repo that use module binaries, and I really don't love the restrictions it adds.
j
I should probably be evangelising for Wave as a Seqeran, and it is awesome, but it shouldn't be required for a language feature IMO
👍 1
m
BTW, the softwareVersionsToYAML function from nf-core-utils plugin does handle a mix of versions.yml and topics version
j
OK, cool, good to know at least!