I was asked to make some changes on my PR which I ...
# hackathon-mar-2026-modules-topics
a
I was asked to make some changes on my PR which I have made Changes Removed legacy
versions.yml
output Added topic-channel version tuple to
output:
block Updated
<http://main.nf|main.nf>
to use
VERSION
variable with
eval("echo ${VERSION}")
Updated tests and snapshots using
nf-core modules test bioawk --update --once
โ€ข Ran
nf-core modules lint bioawk --fix
to update schema I would love to have a re-review before I can go on to pick up another one before the end of the day being the third day.
โœ๏ธ 1
m
do you have a link to the PR? ๐Ÿ™‚
Am i good to go please?
I have now made the changes you suggested. Please, could you take some time to re-review please. Thank you
โœ๏ธ 1
I have rebase my local branch and drop #a64e221
I hope this works now๐Ÿ˜”
m
looks like you need to rebase also on upstream master, because you got some new commits (and a merge-conflict) added
a
Alright
Done
โœ… 1
Can i still continue to work on the modules even after the hackathon?
m
of course. the hackathon is just a more focused event, but we are here on slack all year around ๐Ÿ™‚
a
It was really tasking being my first time on hackathon and as a nextflow user but I really enjoyed it.
m
great to hear!
a
Thank you for your assistant. How best can i celebrate my small win๐Ÿค—
m
I can recommend a cold beverage and scrolling through #C03EZ806PFT and #C07UL3LKR60 or applying the things you learned on a new issue winking cowboy
a
Great thanks๐Ÿ˜ƒ do i need to merge or i should just leave it
m
please merge! that give the extra celebratory feeling ๐Ÿ˜
a
Thank you