https://nf-co.re logo
Join Slack
Powered by
<@U0A2J14RKLH> ChatGPT said that they could not ge...
# genephylo
u
@Patricia Muskus ChatGPT said that they could not get version number. 
tuple val("${task.process}"), val("treerecs"), eval("treerecs --version | sed -n 's/.*(\([0-9.]*\)).*/\1/p'"), emit: versions_treerecs, topic: versions
This code stands for emitting version number. Inside eval, First call treerecs app and make them output version. Second, beyond 
sed
, it cuts out information that bothering. There could be mistake in this sentence, especially inside sed, so I'm trying to fix it now
p
okay!
l
it does output the right string tho
Copy code
treerecs --version | sed -n 's/.*(\([0-9.]*\)).*/\1/p'
1.2
p
mm I see that.. i wonder if it has to do with the smap part
u
I think there are some problem with 
tests/main.nf.test
. I'm looking for that now
and it works with this: simmilar to Lea suggests 
"treerecs --version | sed -n 's/.*(\\([0-9.]*\\)).*/\\1/p'")
@Patricia Muskus I finished correcting. Pls pull latest commit from remote repository
There was typo? in 
tests/main.nf.test
p
yay! how did you fix it?
l
Efficiency! 🎉
🎉 2
u
1. Fixed 
version
expression 2. Fixed typo in 
tests/main.nf.test
Please look at my 2 commitment I did on this 1 hour!
p
thanks @藤田隆弘 for finding my mistake!
u
And @Patricia Muskus Patricia, thank you for adding output correctly!
p
do we need to do a push request again?
l
probably and request review again in the slack channel
p
@藤田隆弘 did you just sent push request a few minutes ago?
u
@Patricia Muskus I pushed it but not for PR. Pls do PR!
Oh, but I received a mail that PR was failed due to linting. @Patricia Muskus Would you mind fix linting for this module?
p
@藤田隆弘 I'm sorry, I had to join a meeting and thought I had sent you guys a message before I left. I just realized I never pushed the "sent" button. Is there anything that still needs to be done for this module? I have some extra time today
u
@Patricia Muskus Shall we gather and finish the work for 
macse
and 
treerecs
? Maybe afternoon
p
@藤田隆弘 I am in Tokyo right now, but I have a couple of hours tomorrow afternoon
✅ 1
u
@Patricia Muskus How about 14:00 from this afternoon?
@Patricia Muskus Oh, sorry tomorrow. It would be fine to have a meeting at tomorrow afternoon! From what time ? Thanks
p
how about 1-2:30?
u
OK!
p
alright, I will find a meeting room. Thanks!
@藤田隆弘 I reserved B648 in lab 2 by IT from 1-2pm
✅ 1
u
OK! Thanks Lab2!
p
@Lea Picard (leapfroggie_) hi do you know where in the nf-core sample datasets should treerecs sample data go in?
l
Hum I'm not sure
I tried to check other modules that use phylogenetic trees as input but the one I found are in a folder called "delete_me" so it's probably not a good idea to follow that example
👀 1
I'd say either: • genomics • generic But maybe we should ask in #CE6SDBX2A or #C043FMKUNLB?
u
@Lea Picard (leapfroggie_) @Patricia Muskus Yes, I think 
delete_me
would be the best choice too!
l
isn't it called delete_me for a reason? I wouldn't put it there
p
alright, I'll post it on #C043FMKUNLB lol thanks both!
🎉 2
u
I mis-understood everything. Posting it would be fine,too!
3 Views
Open in Slack
PreviousNext
Powered by