<#1914 Add pUTI89 FASTA for nf-core module pmlst> ...
# test-data
g
#1914 Add pUTI89 FASTA for nf-core module pmlst Pull request opened by eit-maxlcummins Description This PR adds a plasmid FASTA test dataset for pUTI89: • data/genomics/prokaryotes/plasmids/pUTI89/pUTI89.fasta The sequence is from NCBI accession NC_007941.1 (Escherichia coli UTI89 plasmid pUTI89, complete sequence). Why this is needed For nf-core/modules pmlst, when test input genomes do not contain typeable loci for the selected scheme, pmlst can produce empty outputs. That forces either: 1. hacky module-side workarounds in process/test logic, or 2. proper test data containing typeable plasmid sequences. This PR addresses that by adding a plasmid dataset intended to provide realistic, typeable input for pmlst tests. PR for pmlst: nf-core/modules#10403 Additional benefit The same dataset can support other plasmid-associated modules (for example plasmidfinder) that benefit from plasmid test data. Notes • Path follows modules branch test-dataset conventions under data/genomics/.... • Intended as a stable reusable fixture for module CI and snapshot-based testing. nf-core/test-datasets
Review on #1914 Add pUTI89 FASTA for nf-core module pmlst Review approved by dialvarezs on eit-maxlcummins's pull request LGTM! nf-core/test-datasets
Review on #1914 Add pUTI89 FASTA for nf-core module pmlst Reviewed and changes requested by SPPearce on eit-maxlcummins's pull request Can you please update the README.md file to state that you are adding the file please (and where it comes from). nf-core/test-datasets
Review on #1914 Add pUTI89 FASTA for nf-core module pmlst Review approved by SPPearce on eit-maxlcummins's pull request nf-core/test-datasets