Hi all, I'm working on adding Parabricks GPU accel...
# scnanoseq
g
Hi all, I'm working on adding Parabricks GPU accelerated minimap2 to the scnanoseq pipeline this hackathon. I'll also be adding some subworkflow and pipeline level testing since I don't see any already in the repo.
šŸ‘€ 1
100 rainbow 2
gratitude thank you 1
@Lara Ianov, @Austyn Trull, @Ben Busby I just submitted two PRs: • Adding Parabricks minimap2 to scnanoseq pipeline - link • Updating the Parabricks minimap2 module to be compatible with scnanoseq - link I will probably spend the bulk of tomorrow wrestling with the CI runners and any changes made to dev since I made my branch.
l
Great, thank you!
g
@Lara Ianov @Austyn Trull I added you both as reviewers for my PRs since they're both passing the CI runners and ready to merge. Definitely need to add pipeline tests if Austyn has that PR. Happy to help there, because GPUs on the CI runners can get tricky.
šŸ™Œ 1
a
Awesome thank you!
@Gary Burnett Just to update as well, I've got the template update conflicts resolved -- just testing and currently in the process of writing tests for the other subworkflows, we'll be able to review your PR once we get that in. Thanks so much for your help!
g
Thank you so much. I'm glad I was able to help. I'm looking forward to being an scnanoseq contributor!
l
Thank you so much Gary, we really appreciate your support here. We are excited to run your addition to scnanoseq in the GPUs we have at UAB.
g
Yes once it's all integrated, I would love to know what impact it has on your runtimes with real data.
šŸ’Æ 2
l
We will certainly report back!
g
Hey yall! Wanted to check in and see how the pipeline work is going and offer any help that I can.
l
Hi @Gary Burnett, Thanks for checking-in. We have been split between a few different workflows, but @Austyn Trull is getting back on track for this one. Here are the updates and plans so you are in the loop (some of which we hope to be finished prior to the Summit, but we shall see [depends how it goes...]): 1. We will be updating IsoQuant once more to implement their latest enhancements - the work so far is in our fork and branch: https://github.com/U-BDS/scnanoseq/tree/feature_isoquant_upgrade 2. Austyn has added most of the nf-tests - https://github.com/U-BDS/scnanoseq/tree/feature_nftest ; If you spot anything missing here let us know! 3. I started working on the strick syntax conversion but was not able to finish it during the time I could devote to it: https://github.com/U-BDS/scnanoseq/tree/feature_strict_syntax ; the critical piece missing here is updating the main workflow file including dealing with the version channels which are now being handled through topics. We need to get through 1-3 above, before we implement your GPU work. The challenge here is actually merging all this as well. The plan now will be to 1. Finish the stick syntax conversion (nf-core has a timeline on this so we need to prioritize), and then go from there on the other merged. We will need to test all this pieces of course to ensure we didn't break anything critical. Once we finish the above, we will do a release to that users can benefit from IsoQuant enhancements right away, and then we will immediately move to reviewing and merging your PR. After testing, we will then do another release with just this feature. How can you help? I think that depends on wheather you feel like tackling any of the above with us šŸ™‚ We would certainly welcome the help but we know the scope here is wide. Austyn is out today, but I will let him also give you his thoughts once he is back in tomorrow.
g
Thank you for the update, Lara! I will probably be more helpful when you start to merge the GPU related PRs. I will be at the summit in person if either of you plan on attending.
l
Excellent, I will be sure to ping you here when we get there šŸ™‚ I will be in the summit as well so let's touch base there.
šŸŽ‰ 1
@Gary Burnett: with 1.3.0 out, Austyn and I will start looking into merging your PR and testing once we get back into scnanoseq. We can keep you posted. This is just an fyi.
g
Thank you much for the update and congratulations on the new release!
šŸ‘ 1