Hey folks, <@U08CMJ5V9PB> and I just noticed that ...
# infrastructure
j
Hey folks, @Yuxin Ning and I just noticed that we are already using two variants of the architecture names in our module meta-yamls 😅 There is
linux_amd64
/
linux_arm64
for example in fastqc and
linux/amd64
/
linux/arm64
in multiqc 🫠 Remind us: Did we settle on one or the other form yet? (The blog post uses
_
)
panic mild 2
p
I think that
/
is probably more widely used
but also
/
characters in stuff feel icky
j
Should we just use and
_
then and provide error + with fix during linting?
p
we should definitely error + fix, I don't really mind which we settle on
m
i don't think we need to error+fix, there are only a handful of configs with container defs in the meta.yml in the wild, so no need for the extra code
j
So we assume
_
?
m
I prefer the
_
. but we could still change it if we want. @Phil Ewels @Júlia Mir should we do
linux/arm64
or
linux_arm64
for the container keys in the meta.yml
m
fwiw, the docker cmd uses
/
Copy code
docker run --platform linux/amd64 ...
j
Ok, We assume either one for now. It is pretty easy to change in the code later on or during review
j
I think we had same discussion, docker default is
/
in tools we always use
_
😄
I personally prefer
_
, but also fine if we decide to go with the other
p
yeah I really don't care, just need to pick one
And I think if it's confusing enough to warrant this thread, we should lint for it - should only be a few lines of code
🙌 2
(fine to skip the auto-fix)