Hi! With <@U04NHP6KK0U> we're currently working on...
# pipeline-maintainers
o
Hi! With @Rémy Costa we're currently working on merging this PR for the nf-core/stableexpression pipeline. Since the pipeline is still in dev, it's a PR against the nf-core dev branch. All tests are successful, yet neither Rémy nor me have the right to merge this PR. Can someone tell me what to do? Thanks
quick look 1
m
I guess you need a review
💯 1
o
The thing is that none of us seem to have the right to review it. I just saw that @Maxime Garcia sent an invite to Rémy to be a reviewer. Thanks by the way 🙂
👀 1
m
I added Remi with a maintain status as well, but anyone should be able to review normally since you're both contributors
m
yes, this is weird. please report if it keeps happening. I don't see anything weird in the branch protection rule sets
👍 1
o
do you mean that I should too? Perhaps I missed something but I was not able to review it by myself
m
one can never review one's own PRs. it needs to be another person
o
Yes it's what I had in mind, I wanted to double check. Since it's against a dev branch, it might have been different
[ This is NOT urgent ] Hi guys, I made a new PR against dev and the same issue keeps happening (@Rémy Costa does not have the necessary rights to merge it): https://github.com/nf-core/stableexpression/pull/13 Do you know what could be the reason? Thanks a lot! :)
m
i gave you a approving review, can you check again?
🙏 1
o
Thanks for the approval! However, do you have any idea of what's going on?