Hi, I've tried to update nf-core/phaseimpute to us...
# request-review
l
Hi, I've tried to update nf-core/phaseimpute to use
main
branch instead of
master
. Everything worked but I now have a linting error on the following PR. The issue seems that the TEMPLATE branch isn't in sync with the
main
branch usage. How to fix it ? https://github.com/nf-core/phaseimpute/pull/263
e
Just add something like this:
Copy code
files_unchanged:
    - .github/PULL_REQUEST_TEMPLATE.md
    - docs/images/nf-core-proteinfamilies_logo_light.png
    - docs/images/nf-core-proteinfamilies_logo_dark.png
in the .nf-core.yml file
Copy code
lint:
  files_unchanged:
    - .github/PULL_REQUEST_TEMPLATE.md
    - docs/images/nf-core-proteinfamilies_logo_light.png
    - docs/images/nf-core-proteinfamilies_logo_dark.png
don't forget the lint^
l
I've managed to fix it by pulling from the template the images
git checkout TEMPLATE -- assets/nf-core...
But for the
.github/PULL_REQUEST_TEMPLATE.md
what I fear is for my TEMPLATE branch to be out of sync with my dev branch. @mashehu Do you have an idea what to do ?
m
did you rerun
nf-core p sync
after you changed the nextflow.config? and what is your git config for default channesl
l
I followed https://nf-co.re/docs/tutorials/pipelines/switching_master_to_main So
git config --global init.defaultBranch
is
main
nf-core p sync
does not change anything locally.
I did not update to 3.5.2 version of nf-core. Should I do that before moving from master to main ?
m
nope, 3,5.2 is mostly concerning module linting
l
So, should I ignore
.github/PULL_REQUEST_TEMPLATE.md
until the TEMPLATE is updated with the next nf-core version ?
👍 2
Can I please get a review therefore ?