I had someone message me because their PR (https://github.com/nf-core/modules/pull/8855) was made in parts obsolete by https://github.com/nf-core/modules/pull/10067. I hope the way I handled it is fine. I commented on the other PR and I sent the following messages to the person who asked me:

I think for the next time I would suggest to also create an issue and assign yourself as well as link that issue to your PR. But I commented on their PR that this is not standard practise. They should have at least referred to your PR!

Are there more subcommands for this tool? Because if yes then there are more modules that need to be created.

Are there things in the module that you would have done differently? If yes I would open a PR to apply these changes.

Maybe you can remove the vcfpreprocessor submodule from your PR and just add the

pharmcat

one

Your response is good 🙂