So regarding that: <https://github.com/nf-core/seq...
# team-maintainers
m
So regarding that: https://github.com/nf-core/seqinspector/pull/184 I used a hack since we don't have meta map in MultiQC. But to be honest, and I know @Jonathan Manning agrees with me, having the meta id encoded in such a way in the filename is less than optimal. How would people feel if I were to add a meta map for MultiQC? It could really be useful in case where you run multiple instance of MultiQC per run (ie per samples and so on).
j
For me, as soon as a module gets run more than once in an nf-core workflow it needs a meta map
m
and for me if you run a module more than once you need a tag
extreme teamwork
👍 1
n
Fine by me, it doesn't hurt anyone
m
ok, I'll work on a PR then
m
I’d love a meta map in MQC, we use it too in our pipelines
l
This could definitely be usefull.
m
just the ONE TUPLE
❤️ 1
oh
Now we need to fix the TEMPLATE
😱 1
ok, that's a job for tomorrow me
m
Made a little adjustment, let me know what you think https://github.com/nf-core/modules/pull/10277
👀 1
m
Can you update multiqc_sav as well?
m
Done!
Anyone around to approve the PR? I’d like to merge, so I can start integrating in our pipelines
👀 1
m
I'm still concerned about the linting
I think it should be nested as all is under the one tuple
m
I’ll give it another go
I see what’s going on 😄 I made the input a multiline tuple for readability in
<http://main.nf|main.nf>
, but apperently
nf-core
thinks it’s different inputs because of the newline
@mashehu ⬆️ is this expected?
m
oooh I see
m
nope it's a bug...parsing these things is a pain (until we have a tree-sitter 👀 ), but please make an issue so we can fix it
👍🏻 1
m
@Maxime Garcia, fixed the meta and linting
m
why changing the process name for MULTIQC_SAV?
m
module names can’t have underscores 😅
otherwise it’s <TOOL>_<SUBTOOL>
m
Oh I see
m
Kinda weird this wasn’t flagged when the module was originally merged, but it is what it is 🤷🏻
m
Maybe it's a recent check
Anyhow, I don't think too many people are using this one for now
m
@Delfina Terradas is working on getting it in #CL88J906S
m
Nice, I will have a look and put it in #C06PHJM0Y3D
m
🤔 isn’t #C06PHJM0Y3D more for fastq QC?
mqcsav is for Illumina Sequencer run qc, so I don’t think it’s useful there
m
aha 😄