https://nf-co.re logo
Join Slack
Powered by
<@UQZG2UCF3> <@U03CKGEU3LZ> I'm up to fix the CI a...
# configs
m
@mashehu @Nicolas Vannieuwkerke I'm up to fix the CI as it's blocking everything
n
Okay let me know if you need a review
m
I'll follow your lead for the fixes
Nextflow linting complete! ❌ 54 files had 126 errors ✅ 284 files had no errors
OK, so just 54 files to fix
n
yes and most of these files will be easy fixes, but some are a bit more difficult. I've done 3 difficult ones of which only one works as of now 😁
m
WIP, I'm going in 1 file at a time: https://github.com/nf-core/configs/pull/1019
n
Looks good to me but it definitely needs to be tested on that system first before merging 😛
m
I got most of the linting by replacing ${USER} with ${System.getenv('USER')}
done to 41
n
Yeah I've noticed that too 😛
Nextflow also has a new config function called 
env()
to get env variables, but that's only available in the last versions so not ideal for these configs
m
I am unsure about daisybio
there a whole lot of weird things
n
Yeah it might be worth to just ask the maintainers of that config if it's still used? Otherwise dropping might be better than doing all the work on that one
m
yeah, I am pushing all the quick changes in a single PR, and I will split them all out and ask the maintainers
n
Yeah I don't see anything really breaking about the 
System.getenv
changes 😛
3 Views
Open in Slack
PreviousNext
Powered by