I have a meta.yml file where the topics break the ...
# linting
u
I have a meta.yml file where the topics break the linter. The file is attached, and running the linter with fix results in an error. This happens with 3.5.2 and the dev version (downloaded right now from Github). The error looks the same. Command I used nf-core modules lint rmats/prep --fix &> lint.log I guess it is indenting, but I don't know how to fix it.
m
can you try with this
meta.yml
(there was an indentation error in the last element
u
It fails in exactly the same way, so no change. Sorry. Let me know if you need more info and/or code files.
m
do you have a PR with this somewhere?
u
I can make one. I can also point you to my github branch if that helps?
👍🏻 1
I can't make one, since the meta.yml breaks the github pre-commit hooks. I think my github has everything except the meta.yml. Let me check
Yup, can make PR or point you to branch (which has everything except meta.yml) - which would you prefer?
m
make a PR, easier to checkout 🙂
u
Hi Any luck? I didn't commit the new meta.yml file, but you can use the one you sent me to see it failing. Cheers Uri David
m
sorry, had a full day yesterday, will try later today
finally got to it. Pushed a passing meta.yml to the PR. feel free to continue from there
u
Thank you. What was actually wrong with mine? Just indentation? I'm just confused how it broke the linter...
m
yes, looks like you head "topics" as a top level item and that broke the linter in a weird way
u
So the differences in the headings of file output, from
Copy code
- "*.rmats":
          type: file
          description: rmats junction count information, after processing the BAM file
          pattern: "*.rmats"
To
Copy code
- "*.{}":
          type: file
          description: rmats junction count information, after processing the BAM file
          pattern: "*.rmats"
Are just a style choice? Thank you!
m
ah, that should actually be
*.rmats
, let me push a fix
u
Works. Thank you! I'll keep working on the PR