PR adding a 'contribution workflow/checklist' for ...
# request-review
j
PR adding a 'contribution workflow/checklist' for nf-core/funcscan (single markdown file!) Feel free to suggest anything I may have missed ๐Ÿ™‚ https://github.com/nf-core/funcscan/pull/516
approved with comments 1
Thanks @Jose Espinosa-Carrasco! The second comment was a mistake, for the first one - why was it odd to you (the naming parmaeters)
j
I will separate everything with
_
, since otherwise I have to think what to I do have to keep split and what I donโ€™t but this is very subjective ๐Ÿ˜‰
j
Ah ok, well in this case this is the convention that we have already set so I don't want to change it now ๐Ÿ˜ฌ But generally for us it was because it made it easier at least in the early stages of develop to mass rename whole stuff because the structure was predictable of the parameeter name
When we had extra
_
it was harder to parse
j
fair enough