Hi, I would like to know what to do with all the m...
# team-maintainers
l
Hi, I would like to know what to do with all the modules that use
shell
(deprecated) and
template
when some variable are not used in the
<http://main.nf|main.nf>
. We discussed with @Maxime that the bin folder could be a solution. What do you think ? Here is the linked PR for sratools https://github.com/nf-core/modules/pull/10109/
s
bin folder requires wave containers
l
That's what Maxime told me. What could be really nice would be for template to accept arguments like
template "detect_ncbi_settings.sh" "${args}"
n
What's the reason for it to require wave containers?
m
Wasn't modules binaries requiring fusion?
I was about to ping @Rike Hanssen but she is already replying
r
No just wave: https://www.nextflow.io/docs/latest/module.html#module-binaries but still question remains if we want to rely on the service for standard communnity modules. In that past we have said no, because it means users possibly need to set up something else. I also don't know how this works with running offline... @Jonathan Manning your favorite topic
party this 1
m
pinging Jon was my next move
s
For on-prem servers it doesn't need Wave, just cloud execution
j
What's the reason for it to require wave containers?
Paolo
shakefist 1
paolo 1
r
ah you are right, I missed the line about the local file system
n
Paolo
And how can I convince him to drop that requirement? 😅
😆 1
s
I think it is because the file from the bin folder is copied into the container directly
n
but you don't need wave to do that 😅
j
The workflow bin dir mechanism is some sort of unsatisfactory hack apparently, which we can't extend to module bin
🤔 2
n
That's too bad to hear. But it's not too important to me right now 😛 The regular bin folder is doing enough
j
I know, he and I have spoken. At length.
n
I'm wondering if file staging isn't an option to just put the scripts in the bin folder inside of the process execution env
I don't like the principle of a language feature not working without Wave, but i'm not winning the argument
💯 2
n
Thanks this helped me understand the problem a bit better 🙂
m
Module binaries don’t need Fusion, but the user needs to add a flag in their pipeline code
l
So, how should I solve linting for
shell
and missing variable usage with
template
?
j
Not sure you can right now