https://nf-co.re logo
Join Slack
Powered by
PR to replace the adaptivcard with nf-slack: <http...
# tools
r
PR to replace the adaptivcard with nf-slack: https://github.com/nf-core/tools/pull/4051 since both slack and teams can now be adressed via plugins, I removed it completely from the pipeline code and people can just enable whichever they want by setting the right plugin. For us we just need for the full size testing so it now lives in the workflow file only
🙌 2
question for the team: how do you want the template builder to keep working? At the moment there is a question whether users want slack integration or not. Do you think we should keep that in?
n
True, it's as simple as adding a bit of config now. It might be better to leave it out then?
r
I am all for a leaner template, I think @mashehu wanted to keep it in?
m
still undecided, i don't think this feature was so heavily used. but i guess we still need to communicate the change very well in the changelog, blog post. maybe even add a deprecation notice (but not sure how to do that best, because we had it on by default in the template, so unclear where to surface it best...)
r
yeah good point. Let's ask in pipeline-maintainers who is actively using it (not a good reflection of the user base but at least a start)
👍🏻 1
@Júlia Mir linting is failing here: https://github.com/nf-core/modules/actions/runs/22220493598/job/64274485513 I just removed the imnotification function, did some test requirements change that the utils wfs don't follow?
Is there a way to skpip this, that subworkflow definitly has tests, the naming is just different
@mashehu or @Júlia Mir could I get some help with the failing test (one for the utils workflow not following nf-test naming convention) and the other for test coverage in tools, so this can be merged
👀 1
j
I think the failure about 
main.nf.test
file is comes from when we started enforcing tests also in local modules/subworkflows, we should add a small test for this subworkflow
r
j
oh sorry I didn't see, then yes the easiest will be to rename one of these files
👍 1
p
Where did this end up? It was mentioned on the infra call the other day, did we decide to keep it in, in the end? (for nf-core slack integration mostly?)
r
it was merged into the template: https://github.com/nf-core/tools/pull/4051
@Maxime Garcia already tested it in seqinspector: https://nfcore.slack.com/archives/C06PHJM0Y3D/p1772464182707709
m
yes, I was actually incorrect during the infra meeting. nf-slack is in the template
but not as a skip_feature trigger and no linting for it
r
but decided that people should use the plugins if they want and that that bit is removed from the template. I would love to link th website PR but Github is not loading 😞
m
I can add it to the pipeline health page if we want
r
m
It does works flawlessly
once you manage to write properly 🤣
Fixed the GHA for it-> https://github.com/nf-core/tools/pull/4092 as it was displaying 
matrix.profile
and not 
test_full
I am wondering about merging both awstest and awstestfull actions and disabling notifications for awstest
m
nope, they have different triggers, but with some work, you might be able to merge them
2 Views
Open in Slack
PreviousNext
Powered by