And another question: `pipelines lint` tells me th...
# linting
n
And another question:
pipelines lint
tells me that my local subworkflows have issues. However, I am somehow unable to get
subworkflows lint
to also check my local subworkflows, i tried
nf-core subworkflows lint <subworkflowname>
,
nf-core subworkflows lint local/<subworkflowname>
and
nf-core subworkflows lint subworkflows/local/<subworkflowname>
m
try
nf-core subworkflows lint <subworkflowname> --local
n
also does not work;
Copy code
nf-core subworkflows lint assemble --local
ERROR    Could not find the specified subworkflow: 'assemble'
the subworkflow should be there:
Copy code
ls subworkflows/local | head -n1
assemble
also
subworkflows lint --local
also only looks at local nf-core subworkflows
m
hmm, just tested and
subworkflows lint --local
lints all
<http://main.nf|main.nf>
in
subworkflows/local
n
interesting, I will take another look
m
just to be sure, can you check
subworkflows lint --local -passed
n
I will check that in a second, since I just wrote subworkflows, and did not make use of
subworkflows create
is it possible that this makes them not findable?
m
what is the structure of your local subworkflow?
n
Which brings me to my next question, is there some way to create a
meta.yml
for existing subworkflows?
m
very possible we miss it
n
it is
subworkflows/local/name/main.nf
m
to create a meta.yml, touch it and try with
lint --fix
🙌 1
n
or do you mean structure of the actual workflow?
m
you can check with
nf-core --verbose subworkflows lint --local
if it drops them for some reason
n
also
subworkflows lint --local
also only looks at local nf-core subworkflows
this was incorrect,
list local
only looks at local nf-core
m
yes, local here means: in this directory vs. in the modules repo
n
ok, so
subworkflows lint --local
does indeed lint all local subworkflows, but it does not seem to work with a named swf
lint --fix
does not seem to fix anything on empty meta.ymls
m
what do you mean with "named subworkflows" exactly?
try to copy another meta.yml and try again with
--fix
?
👀 1
n
i mean that it works with
nf-core subworkflows lint --local
but not with
nf-core subworkflows lint <name> --local
m
ah, true. can you make an issue for that please?
n
Sure
It seems like
--fix
does not do much to the subworkflow meta.yml
a
I think local linting doesn't do fixes
ohno2 1
There's a lot that I skipped with local linting because it was deliberately intended to be permissive
n
Well, if I can just ignore the warnings about
meta.yml
that works for me 😉
a
They shouldn't lint by default in CI I don't believe, so really it's up to you what you choose to ignore. But maybe that was changed in the template at some point
n
I think it would be nice if they had meta.ymls, but I am not very keen on creating them manually