https://nf-co.re logo
Join Slack
Powered by
Overhauling Illumina demultiplexing modules <https...
# request-review
m
Overhauling Illumina demultiplexing modules https://github.com/nf-core/modules/pull/10057
👀 1
✅ 1
@Simon Pearce, this one’s for you
m
minor comment
Looking good already
thinking about your function for the readgroup
How about we migrate it to plugin?
m
The one for 
bcl2fastq
should look familiar, I stole it from #CGFUX04HZ 🤣
How about we migrate it to plugin?
We could, but I think it would be more hassle then it’s worth, since it’s very specific for the output from each module respectively
m
I plan to migrate these functions from sarek already https://github.com/nf-core/sarek/blob/dev/workflows/sarek/main.nf#L649-L716
I think there are ways we can make it modular
m
The 
bclconvert
one I would keep attached to the module. @Simon Pearce saw some serious slowdowns when using the previous iteration on cloud (as do we)
🫠 1
The 
bcl2fastq
one could be used elsewhere as a more general approach
m
Good catch
m
Comment addressed!
m
still some issues
m
all checks passed, ready to merge
Thx Maxime
3 Views
Open in Slack
PreviousNext
Powered by