Hiya. Without customisation of workflows in sarek...
# sarek
a
Hiya. Without customisation of workflows in sarek, is there currently a route for having fastp trimming (for library adaptors) prior to passing these trimmed outputs to the UMI worklflow for extraction/grouping/consensus calling? Or having fastp extract UMIs prior to pushing to UMI workflow?
s
I implemented some extraction ability from fastp, see https://nf-co.re/sarek/3.8.1/docs/usage#how-to-handle-unique-molecular-identifiers-umis Basically UMIs are awkward because there are various places that they can be located.
I would also suggestnf-core/fastquorum for making consensus reads rather than using sarek personally
this 1
a
Yeh, ok thanks.. But if you extract using fastp currently I don't think this can be passed (without workflow tweaking) to the grouping/consensus read building with fgbio tools. I would want to (best practises) trim adaptors etc. prior to doing consensus building . Just doing deduplication via GATK MD is possible, following extraction of UMI via fastp, but you're not then getting the most out of using UMIs (especially for high-coverage cancer pipelines) . Appreciate most can be done with use of
fastquorum
up front (before sarek), but I'm considering this for a clinical pipeline so version controlling two nfcore based pipelines (forked and customised anyway) is less desirable.
s
Yes, the current setup is fgbio before fastp. That could be changed if you are motivated enough.
The pipeline currently uses fastp for splitting the fastq into chunks for parallelisation. When I made some modifications to the UMI processing I didn't really touch the consensus generation part.
a
Thanks. Yes will perhaps look at putting a second fastp option (and/or cutadapt to allow more control of 5' sequence trimming) inside the
fastq_create_umi_consensus_fgbio
workflow and associated options to run (or not) the current fastp task. .
@Simon Pearce Hiya. So I'm looking to add a few new things to sarak for our local pipeline requirements, including the extra trimming step I mentioned above. I'm not sure how useful these may be in the wider context, but happy in input back in to the pipeline as desired. Should I just send pull request for a forked version to see if you think any of my customisations are useful and pushing back to main is an option?