https://nf-co.re logo
Join Slack
Powered by
Can someone help me to understand&fix this :sm...
# nf-test
k
m
@Nicolas Vannieuwkerke I believe we need to bump java, right?
k
Copy code
🚀 nf-test 0.9.3
<https://www.nf-test.com>
(c) 2021 - 2024 Lukas Forer and Sebastian Schoenherr

Load .nf-test/plugins/nft-anndata/0.1.0/nft-anndata-0.1.0.jar
Load .nf-test/plugins/nft-bam/0.6.0/nft-bam-0.6.0.jar
Load .nf-test/plugins/nft-csv/0.1.0/nft-csv-0.1.0.jar
Load .nf-test/plugins/nft-compress/0.1.0/nft-compress-0.1.0.jar
Error: Syntax errors in nf-test config file: java.lang.RuntimeException: Plugin'nft-fastq' found, but version 0.1.0 not found.
details form my local
m
delete the .nf-test folder locally
k
okay false alarm 😄 it still works on my local producing same snapshot
I guess you need to bump java version
m
got it
n
yeah that might be it! even though I didn't raise the minimal java version 🤔
m
yeah, but we actually don't install it in the shard action
confused dog
n
It's installed with Nextflow, I think?
m
no idea which version
I used the same setup we have in the nf-test action
n
true, better to pin it
m
I bumped to 23 for ALL java
🙏 1
@mashehu wants to keep 17
@Nicolas Vannieuwkerke wants to bump to 23
you can't both ask me to make opposite changes
m
github runners come with 11 by default, that's why it worked before i guess
n
I'm fine with either
m
better to be conservative for tests imo. we say we support 17, let's keep it at that
m
ok
I'll keep 17 for now then
n
having it at 17 means we will have to bump again in a year or so maybe
👍🏻 1
👍 1
m
it's a minor inconvenience
Can I get approval now?
m
drop the setup-nextflow step please (sorry to be a pain, but i have been burned to often with github actions)
m
ok
no worries
n
Weird that it kept working though since Nextflow has also dropped java 11 support
m
we're back to my initial proposal now 🤣
🤣 1
k
Thanks for fixing this so fast exceptionallyfastparrot
👍🏻 1
9 Views
Open in Slack
PreviousNext
Powered by