Ambitious PR to add a new MultiQC variant. <https:...
# request-review
m
Ambitious PR to add a new MultiQC variant. https://github.com/nf-core/modules/pull/9587
👀 1
m
So if I understand well, this is tiny modification on the regular MultiQC, on which you add an extra input channel and the plugin so that it can run nicely on the Illumina rundir
m
Yep, that’s it Container including the plugin + new input and some staging magic to make it work
m
And we would probably want to include this in more than 1 repo
so having a patch would be a bother
m
I would think so
m
cc @Phil Ewels, just wondering the same question again For me if we manage to automate nicely the update, I wouldn't mind having multiple flavors of the multiQC with dedicated plugins, but it's a slippery slope
m
Do we make it a subtool of multiqc then?
and what about multiqc with multiple plugins?
p
If it's just a different container (like it is for xenium) then I think a local patch to switch out the containers is fine
/ conda requirements
In this case, there needs to be a bunch of extra logic around inputs and data structuring for MultiQC to handle the report generation properly
So it sounded to me like a separate module was probably warranted, as that's a bit exceptional (usually MultiQC "just works" without any faffing around like this)
party this 1
Whether it's a local or a shared module.. 🤷🏻‍♂️
m
> If it’s just a different container (like it is for xenium) then I think a local patch to switch out the containers is fine There’s no need to patch, you can fix it in config
👍🏻 1
tru 1
m
Agreeing on the new module for this
👍🏻 1