Just updating the fastq preprocessing subworkflow ...
# request-reviewj
Jonathan Manning
12/18/2025, 10:21 AMJust updating the fastq preprocessing subworkflow in #CE8SSJV3N to take advantage of the new rrna removal options developed for #C05785S3TMX: https://github.com/nf-core/rnaseq/pull/1664
(also MultiQC config improvements including new module for bbsplit)
✅ 1
Jonathan Manning
12/18/2025, 10:40 AMThanks @Maxime Garcia! About 2ms after merging I realised I'd forgotten to add ARM container listings for the new modules
m
Maxime Garcia
12/18/2025, 10:42 AMoh
Maxime Garcia
12/18/2025, 10:42 AMObviously
Maxime Garcia
12/18/2025, 10:42 AMwe need to automate that
j
Jonathan Manning
12/18/2025, 10:42 AMI'll sort it
m
Maxime Garcia
12/18/2025, 10:42 AMlooking amazingly nice
Maxime Garcia
12/18/2025, 10:42 AMBTW, you're not running the tests from nf-core/modules, right?
Maxime Garcia
12/18/2025, 10:45 AMI added that to #CGFUX04HZ and #C01NHS4CC91 :
https://github.com/nf-core/sarek/blob/dev/.gitignore#L17-L18
and deleted ALL tests folders in modules/nf-core and subworkflows/nf-core
I like the possibility to do test, but I know how messy it is within the pipeline due to config collision.
And I really wish the tests would be opt-in, so in the meantime, that's my hack to remove lots of unused lines
j
Jonathan Manning
12/18/2025, 10:49 AMBTW, you're not running the tests from nf-core/modules, right?Not unless I broke something. Should just be pipeline and local components
🙏 1
m
Maxime Garcia
12/18/2025, 10:50 AMyeah same, the only tests from modules and subworkflows I run are the local ones
2 Views