https://nf-co.re logo
Join Slack
Powered by
<@UPC8CHDKQ> what we just discussed, with the impr...
# sarek_dev
m
@Rike Hanssen what we just discussed, with the improvment on the tests: https://github.com/nf-core/sarek/pull/2080/files cc @Famke Bäuerle as you might want to compare with #C05URH17X5Z
👌 1
👀 1
thinking of adding the default inclusion of WARN from https://github.com/nf-core/sarek/pull/1986 in this one while I'm doing it, what do you think?
r
that would be great
m
On it
I forgot we actually have warnings in normal running stage of the pipeline
Copy code
"WARN: FASTQ file(/nf-core/test-datasets/modules/data/genomics/homo_sapiens/illumina/fastq/test_1.fastq.gz): Cannot extract flowcell ID from @normal#21#998579#1/1"
ok, so this is taking slightly longer time than planned, but looking AMAZING
ok, quite happy with the way it's turning
I had to tinker a tiny bit, but I'm getting quite happy with this to be honest
I'll try to talk with other devs to see what they're doing, and see what else is needed, so we could make this more modular and shareable
I'm quite happy on how simple 
tests/bbsplit.nf.test
looks now
only issue in this PR is tests/variant_calling_freebayes.nf.test.snap that is completly jumbled now shakefist
@Rike Hanssen ok to merge now?
I feel like I have pre-approval, but that was before ALL the extra change
r
will check. just got on the train and fought a posh lawyers for my seat.
m
Was it a fist-fight or could it have been a meeting?
r
my hoodie and general slackness made me a suspicious person in first class.
m
and now you're adding a computer and doing weird stuff on the command line
r
shared a GIF
😆 1
m
Thanks
I'll be merging then
excited dog 1
2 Views
Open in Slack
PreviousNext
Powered by