<#C07NY6CGWPP|> PR ready: <https://github.com/nf-c...
# wg-container-conversion-task-force
e
m
@JĂșlia Mir can you have a look? you have the most experience in how things should look like
e
Until the pipeline conforms to the nf-core rules about containerization per-module, I've left a pipeline-wide container / env, as it currently is in the pipeline (other than the unzip modules)
j
as a first comment, the module name sin the config files will only contain the module name, not the whole path. I think it would be better to start testing it like this already so see if we find any problems
e
ok!
So I guess instead of writing all three variations of the same module, it should be enough to write just
UNZIP
?
j
yes!
e
even better
j
you could dubplecheck with
nextflow inspect -format config
that it only outputs
UNZIP
once
e
nice command, didnt know that 😛 yep, only once
In the end I made the swap to the nf-core
unzip
module +patching it to work similarly to their old local one. Also updated the end-to-end snapshot and seems green to merge
🎉 1