Poll for you all <!channel> When checking the sta...
# team-maintainers
j
Poll for you all <!channel> When checking the status of your tests, do you: 1️⃣ check the summary at the bottom of the 'conversation' tab of the PR 2️⃣ use the 'Run nf-test' summary page on the 'Checks' tab ???
m
but 2️⃣ when there is something off
➕ 8
or when I am actively watching a CI run
j
OK, to give context why I'm asking: Was having a conversation with @Diego Alvarez Saravia where he said 'what is the point of the
latest-everything
if we ignore it because see it always 'passing' - heating the planet 😅 '
Which Is I think a fair point
I'm wondering if we should drop
latest-everything
tests to only release PRs?
m
it helps us debug if we see something going wrong
j
Because I have a feeling mkost people don't use 2️⃣ so are not even using those tests for anything
m
(plus it gives a nice festive pattern 🎄)
😂 4
😆 1
j
in theory we (the bot) were posting a comment to the PR when the latest everything failed
did this ever work?
meow no 1
j
But regardless, I sort of feel it would make more sense to only run it on release PRs to save a few polar bears, given that most people are just never checking 2️⃣ anyway (it takes too many clicks to get to it), and make it ACTUALLY fail
And I don't think we've been burnt by the edge release doing something weird very regularly
j
also we now have the nightly builds which tell us when something fails, so I agree we can remove this from the tests
👍 3
j
m
nightly != latest everything. but we test latest everything in the tools CI, and that should hopefully capture most things.
👍 1
🤔 1
n
I agree that it makes more sense to test this only on PRs from dev to master/main. However it might also be a good idea to have them fail, but not be required to merge the PR. That way we have a visual indicator that something is wrong
this 1
r
I am leaning towards Nicolas proposal. I get to keep test minimal for the 🐻‍❄️ . On the other hand nothing more annoying then finally getting a release PR approved only for all tests to start failing due to some stupid syntax error that is not supported anymore in nextflow.
this 1