https://nf-co.re logo
Join Slack
Powered by
Can we make a decision on what we are doing about ...
# team-maintainers
s
Can we make a decision on what we are doing about Harshil Alignment? The language server appears to be unable to keep it, so we end up with lots of wiggly alignment on PRs.
this 1
j
don't question the bot.
j
To me it simplifies reading the code but if the language server does not keep it then it is very annoying to have to redo it each time
party this 1
j
Also the Harshil alignment is not necessarily consistent between people all the time in some cases
s
I just don't use the bot?
j
You don't use the language server / formatter you mean?
s
I use the language server, but I don't use the formatter
this 1
👍 1
j
(that's what I mean by the bot)
m
so should we have "harshil-alignment" according to the formatter?
j
I have it on, but it doesn't do 'all' the alignment
s
Yeah, it doesn't seem able to actually format properly
this 1
hence why I don't have it turned on
j
image.png
Wait, what is the @Mahesh Binzer-Panchal form 👀
j
hahaha, I am becoming jealous
s
It puts process outputs at the end of the body instead of the top
(as it says)
input: script: output:
😱 3
j
How have I not hear about that before 😱
j
I have not hear about it either 😱
m
where are the docs winking cowboy
💯 1
s
It feels like @James Fellows Yates and @Maxime Garcia have decided to just give in to the bot
💯 3
🍪 2
j
Jose’s from
Copy code
script:
output:
input:
😆
😆 1
😁 1
m
What did I do again?
s
but that doesn't necessarily mean we have to pay attention to that
😁 1
j
I dunno, I realised I got tired of manually having to align everything
sad cowboy 2
💯 1
And then fixing it when other people did it WRONG
💯 1
@Mahesh Binzer-Panchal please make your specification doc alongisde Harshil AlignmentTM
Mahesh FormTM
m
Yeah. I like my code in the order:
Copy code
input:
// directives:
script:
output:
so I had to compromise and take:
Copy code
// directives
input:
script:
output:
👍🏻 1
👍 2
j
I see the logic
m
I don't think anyone but me is using it
and I don't use it on nf-core
j
doesn't matter
We need it
p
Doing full Harshil alignment with the formatter is difficult, so it does a best-effort
At the moment there is no enforcement, whilst it is unable to not accidentally remove lots of code comments this is fine fire
But I'm hoping that this will be fixed soon™ and then we can switch it on for nf-core and run it in the CI / pre-commit etc.
🔝 3
🙏 1
If you can spin up any minimal examples of where it doesn't do Harshil alignment as you'd expect (which are not super complex) then feel free to throw them at the language server repo and try to guilt-trip Ben into spending time on it 😆
2 Views
Open in Slack
PreviousNext
Powered by