https://nf-co.re logo
Join Slack
Powered by
Possibly midly controversial PR: <https://github.c...
# tools
j
Possibly midly controversial PR: https://github.com/nf-core/tools/pull/3891
j
As someone whose main interaction with nf-core (outside of helping here and there with #CE9MS66BS, of course 😉) is using the the nf-core framework for external pipelines, I wonder if the thing to do is to emphasise the difference between the framework (template, tools, modules, etc.) from the set of community-developed pipelines? Something like: • This is an nf-core pipeline - your pipeline has been accepted via the [nf-core proposal process](https://github.com/nf-core/proposals) • "I just want to use the nf-core framework!" - you want to develop your own pipeline using the nf-core tooling
j
Yeah exactly
Thats what we should go for, but I don't think (?) system is not allowing enough find grain control... e.g. it looks like for example (not tested) you have to have the nf-core logo if you want the github actions yaml files/infrastructure (which in some cases I guess you could still reuse? I'm not sure now with the runs-on stuff) I think we've underestimated how many people are using the full nf-core template outside of our own stuff
j
AIUI we use the GHA stuff fine with the template in non-nf-core-mode - if you turn it off it's just configured to use the standard GHA runners
👍 2
I think we've underestimated how many people are using the full nf-core template outside of our own stuff
Should the "is an nf-core pipeline" option be set to off by default?
j
That's what I argued we should do but core team members were not sure
i think we need to overhaul that whole thing basciallyu
j
I can understand not wanting to do it, it does send mixed-messages
i
We would need some market research, but it could be useful to have a way to create a full template quickly, without the branding. With a small patch (which I'm not brave enough to create at the moment), the logo generator could even be expanded to create logos with the creator's user/org name and a note along the lines of "made with nf-core tools"
👍 1
j
That is something that's missing from the non-nf-core-branded template. With the latest template update I had to manually add back in the section where you can even define the ASCII org logo (we have out own).
💯 1
p
@Júlia Mir some good feedback here ☝🏻 We should try to write up a couple of GitHub issues on these ideas.
Note that some of what you guys are asking for in this thread is already possible, I think 🤔 But maybe we need to review the UX.
j
It's entirely the UX, and I think decoupling the branding (which i think is still too tightly linked to other stuff)
p
Maybe need 3 options then
j
Yeah tha'ts what I put in the 'description' of the PR
p
• nf-core, incl branding • full fledged framework but no branding • lightweight
j
1. Official nf-core pipeline (accepted via nf-core/proposals, includes branding such as logos, full template) 2. Unofficial nf-core pipeline (not accepted/not proposed via nf-core/proposals, excludes branding such as logos, full template) 3. Custom nf-core pipeline (not accepted/not proposed via nf-core propsoal, excludes branding such as logos, bare minimum template with fine grained opt-in/opt-out options)
Which I should put in an issue but for now wanted people to complain 😉
p
I don't think "unofficial nf-core" is the right name, but yeah I think we're on the same track here
👍 1
j
What would you look for @Jim Downie?
In terms of terminology
j
I would go something like • official nf-core pipeline • nf-core framework pipeline the latter can either be full or custom
👍🏻 2
this 1
👌🏻 1
j
very nice feedback! I want to read all the opinions more in detail 😄 but in general I agree, and as Phil says most of this can already be done, we just need to explain better in the TUI
👍 2
Open in Slack
PreviousNext
Powered by