I'm trying to update the bases2fastq module to the...
# team-maintainers
s
I'm trying to update the bases2fastq module to the most recent version. It now by default runs multiqc on the output (as well as making its own html QC file, which confused me for a while with an nf-test error) The tool accepts
--skip-multi-qc
as a flag to turn this off. What do we want to do in nf-core/modules?
m
I am summoning @Phil Ewels But personally I am for disabling that. I want my MultiQC report to be a single final report, or at least one per sample or whatever, but not one per tool. For me the whole point of MultiQC (on top of beautiful graphs) was to have a single final report. I don't want a tool that gives me a MultiQC report.
party this 1
s
(if nothing else, we can turn it off in the demultiplex pipeline)
m
I would say it would be simpler not to do a thing and disable it with args whenever we use this module. Hardcoding this params would be bad practices in my opinion, even if it's the road I am advocating for
s
Yeah, I think that is probably a bad preference precedent. I have set the channel to optional 😉
🙏 1
m
good enough for me
s
m
For me right now we know, so we can include this flag in our ext.args by default in the #CL88J906S pipeline, as I'd think that's how it should be run there