https://nf-co.re logo
Join Slack
Powered by
<@UV41DBFAT> I have 4 PRs that <@U03CKGEU3LZ> appr...
# nf-core-utils
m
@Edmund I have 4 PRs that @Nicolas Vannieuwkerke approved, can you have a look and see if you have comments, I'd love to be able to merge in and release as it's a blocker for me now
salute 1
also it would help a lot with #C09LJTQQ3EY
e
I've got some changes, I'll review them by Monday!
m
Thanks
A bit confused by the comments to be honest
are they duplicate or not?
ai thumbsup 2
e
They were supposed to be in line reviews
So I'll have to do it the old fashioned way and manually paste them in
m
I see
Included the changes
and update the tests
I realized that the LS for nextflow 25.10 is breaking pre-commit and if I follow the suggestion it's breaking the tests
😱
I'll try to fix this
this basically:
Copy code
-        catch (Exception e) {
+        catch (e: Exception) {
shakefist
n
shakefist
m
iep that's an error
I'll pass by skipping pre-commit. Could you report to syntax, I still have issues with the nextflow slack
n
Can you write it out here? I'll crosspost it again then 😛
m
Due to Nextflow 25.10.0 LS, we have this modification that is now appearing:
Copy code
-        catch (Exception e) {
+        catch (e: Exception) {
But it's not valid Nextflow 😱
To be fair, I don't think we should be handling try / catch this way, but I am not trying to fix something I did not write at this level
n
Posted!
m
thanks
n
did you set 
NXF_SYNTAX_PARSER=v2
?
from Ben
👀 1
m
I don't see no changes with this
shakefist
n
I'll just tag @Ben Sherman here so you can continue your conversation right here 😉
🤣 1
m
ok, I am deleting the catch e exception
it's just for tests, I don't care how nice we catch exceptions or not
In the end I did this: https://github.com/nf-core/nf-core-utils/pull/29 these validation tests are not optimal and in need of some improvments
I started working on it with nft-utils, but I need a nft-utils release before I can go forward with this
I'll be self merging 29 and fixing the merge conflicts so we don't block the other PRs
OK done
please review/comment/merge/release when you can, if not, we can have a session monday morning when starting the hackathon, I'll try to follow remotely as much as possible
@Edmund noticed and merged your PR to 24
nf core pet 1
you just assigned me to it, but it's my own PR
Open in Slack
PreviousNext
Powered by