https://nf-co.re logo
Join Slack
Powered by
Can I get a review on this PR adding support for N...
# nf-schema
n
Can I get a review on this PR adding support for Nextflow 25.10.0 and Java 25 to nf-schema? https://github.com/nextflow-io/nf-schema/pull/180 I'll take a look at the globbing issue after this
👀 1
m
LGTM, but I don't have any power over there unfortunately
n
No worries, thanks for the review!
m
Can I gain some power here, or is it a lost cause to ask for it?
n
I can't give that to you but I know @Phil Ewels does have the power 😉
🙏 1
p
@Maxime Garcia - added
extreme teamwork 1
@Nicolas Vannieuwkerke is this change still needed?
I thought that NF was given an alias to be backwards compatible with the class name change?
n
Yes that's true, but I did the change before then. The PR also adds support for Java 25 so it's still worth merging
Seems like @Maxime Garcia still does not have write access, his review is still not valid for the check
ohno2 1
m
@Nicolas Vannieuwkerke Maybe I actually needed to ACCEPT the invite?
🤣 1
You're GOOD TO GO
n
Awesome I'll take a look in 15 minutes 😛
p
@Nicolas Vannieuwkerke yup, but if you use the alias then you don't break backwards compatibility, right?
So even if you did the change I was wondering if it was worth undoing the change for that reason
Putting it off for ~6 months or so to try to give some breathing room around stable releases
n
Yes, that's why version 2.5.1 still works perfectly now 😛
2.6.0, which I'm about to release, contains support for Java 25 and a bug fix only happening in 25.10.0, but is exactly the same in functionality to version 2.5.1. I will just release this for pipelines that break with the new version but 90% of all pipelines can still safely use 2.5.1
m
🚀
folders are handled differently right?
thinking how big the radius could be actually
n
Nothing changed in folder handling. The only thing fixed is the handling of glob patterns existence 😛
m
that's what I though, just wanted to be sure
🎉 1
p
I will just release this for pipelines that break with the new version
But there aren't any of these now, right?
n
Sarek and Rnavar break in 25.10.0
and probably some others that I don't know about
p
Even with the alias?
n
They break because of the globbing issue, the alias is not an issue anymore
p
ok cool - sorry I managed to miss the globbing thing. That's specific to 25.10?
n
Yes it's something that shouldn't even work in older versions, but somehow it does 😛 Something got updated in 25.10 that caused this to finally break
m
how is this even working then?
n
shared a GIF
p
Ok but the fix doesnt work with older versions?
Sorry, I feel like I'm being very slow here
Multi tasking a thousand things
m
the problem doesn't exist (somehow) in older versions
this new globing issue seems to have appeared suddenly
p
Yeah but that's not the same thing as the fix not working in older versions
m
right
n
the fix should work in older versions, but not the Java 25 support 😛
anyways, nothing had to be fixed in the older versions. This just gives people in the new versions a fix
p
What I'm worried about is that by changing the class name, from this version onwards all new releases will be 25.10 only
n
yes 2.6.0 is 25.10 and up only 😛
p
So if we reverted that change, kept the glob fix and the j25 support, then it would remain backwards compatible
n
We will probably have to do this quite frequently in the future with syntax updates
I'm not that set on retaining backwards compatibility on newer nf-schema releases, you don't have to use a newer version as soon as it releases 😛
p
Fair enough 👍🏻
👍 1
Open in Slack
PreviousNext
Powered by