Good afternoon. I want to merge <https://github.c...
# team-maintainers
m
Good afternoon. I want to merge https://github.com/nf-core/modules/pull/9033 as is, but there are failure. I don't think we can fix them all, and I have pestered @Matthias De Smet enough. I was wondering about adding these tests to the ignore conda list, and create issue to remember about it. Yeah party dead or nay ohno2
party dead 4
ohno2 1
@Famke Bäuerle @Rike Hanssen @Nicolas Vannieuwkerke @Simon Pearce @Adam Talbot and any other people using GATK
n
only conda tests fail so I don't see any problems 😉
s
create issue to remember about it
You mean completely ignore it forevermore?
🤣 1
m
nope
I remember ALL my issues
r
I purely don't want this merged so we can release sarek first 😛
😆 4
s
shall we create an issue to remind us about the issue?
🤣 1
m
Related to the issues in this PR, I’m looking into
manta
. It appears there’s an older build of the container used in the module. I also notice
manta/convertinversion
has a requirement for
samtools
, solely for the sake of a tabix index.
@Rike Hanssen, since you’re the maintainer and only known user of this module, how would you feel if I drop the
tabix
and
*.tbi
output from this module, for the sake of simplicity?
Nevermind, the python script also depends on samtools
m
I was about to say NO
I got your back Rike
❤️ 1
m
I’m preparing another PR that bumps
manta
to the latest build and pins the python version, which I hope will fix the
libboost
error
🙌 3
So how about it?
m
ok so only failures with conda/gatk left
that's ok for me
❤️ 1
Could you be so kind and create an issue for the conda erroring modules with as much info as possible?
👍🏻 1
so we know about it
and comment said issue in this PR?
I'll merge it in the meantime
OK, so GATK4 modules update has been merged with the remaining conda errors that couldn't be fixed for now, but Matthias has created issues for it, so we know and we will either pay attention or ignore (but knowingly)
m
m
wonderful recap